Ticket #96 (closed defect)

Opened 6 years ago

Last modified 6 years ago

Possible incorrect expression precedences for DotReference, BracketReference and CallExpression

Reported by: untyped Owned by: dherman
Priority: major Milestone:
Component: dherman/javascript.plt Keywords:
Cc: Version: (7 3)
Racket Version: 4.1.0.4

Description

Hi Dave,

I think there's a pretty printing bug in versions 6 and 7 of javascript.plt. You gave DotReference? and CallExpression? a different precedence in version 6 (they were the same in version 5) and it causes some expressions to render in odd ways.

I've attached a new version of private/tests/pretty-print.ss containing extra tests that illustrate the problem (see lines 51 to 102).

I've also attached a version of print.ss with slightly altered precedences that make all the tests work (including all the test cases in Mirrors).

I think we're getting very close to library harmony now (pun intended).

Cheers,

-- Dave

Attachments

pretty-print.ss Download (8.2 KB) - added by untyped 6 years ago.
private/tests/pretty-print.ss
print.ss Download (22.1 KB) - added by untyped 6 years ago.
print.ss

Change History

Changed 6 years ago by untyped

private/tests/pretty-print.ss

Changed 6 years ago by untyped

print.ss

Changed 6 years ago by dherman

  • status changed from new to closed

Excellent! Thanks for the fix. It's applied in 7:4. (Nice pun.)

Note: See TracTickets for help on using tickets.